search

apollo-rsps / apollo

An open-source Java game server suite designed to be lightweight, fast, and secure.
ISC License
186 stars 141 forks source link

Redundant abstract modifier in SynchronizationBlock #539

Closed JayArrowz closed 3 years ago

JayArrowz commented 3 years ago

https://github.com/apollo-rsps/apollo/blob/87553a83840503815ce9d0a1dd39a28855d3b561/game/src/main/java/org/apollo/game/sync/block/SynchronizationBlock.java#L18

There is nothing abstract in this class

JayArrowz commented 3 years ago 
it's there because there's a List<SynchronizationSegment> somewhere
or a similar container type
so it's a bit safer/cleaner than List<Object>, which would be the alternative if you got rid of it