Fixes incorrectly decoded querystring for GET requests

apollo-server-integrations / apollo-server-integration-aws-lambda

An integration to use AWS Lambda as a hosting service with Apollo Server

MIT License

46 stars 9 forks source link

Fixes incorrectly decoded querystring for GET requests #122

Closed BlenderDude closed 1 year ago

BlenderDude commented 1 year ago

Closes #120

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 56fca54156f853d8a0118ff1afede376528c18fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------------- | ----- | | @as-integrations/aws-lambda | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 56fca54156f853d8a0118ff1afede376528c18fe:

Sandbox	Source
apollo-server-integration-aws-lambda	Configuration

iiroj commented 3 months ago

I believe this change causes issues for requests coming through an AWS API Gateway, because the API Gateway already decodes the parameters. Using difficult characters like % leads to double-decoding and produces a Malformed URI error with status code 400.

Is the intention that we manually encode them back before passing the event, or can this be considered a bug?