apollo-server-integrations / apollo-server-integration-fastify

An Apollo Server integration for use with Fastify.
MIT License
67 stars 13 forks source link

Add support for fastify 5 #297

Open zckrs opened 1 month ago

zckrs commented 1 month ago

Fixes #296

marcoreni commented 4 weeks ago

@trevor-scheer Any chance of getting this reviewed? It seems like almost no changes are required and it would unlock the ability to upgrade to Fastify 5.

wturney commented 3 weeks ago

Fastify 5 appears to have changed the order of their generics for at least one type.

Specifically:

FastifyReply now uses RouteGeneric as the first argument. This results in a typing issue in this project for ApolloFastifyContextFunctionArgument. I assume they did this so it matches the argument order in FastifyRequest