search

apollo-server-integrations / apollo-server-integration-hapi

MIT License
3 stars 3 forks source link

Add multiple: true to plugin #56

Open HananeMoshe opened 12 months ago

HananeMoshe commented 12 months ago

How does the community feel about adding multiple: true to the hapi plugin. I have a few apollo graphql services that add multiple endpoints and need to register the plugin multiple times.

Adding multiple: true here solved the problem and is common in hapi plugins. I am more than happy to create the pr if we are ok with it?

Thank you.

arimus commented 11 months ago

@HananeMoshe sorry for the late response. I'm not particularly opposed, except that the reason this is usually set to false is so that folks are warned about inadvertent multiple registration issues. We could also provide an alternate entry point or some config to enable this as needed. For your case, you might also be able to just set multiple onto the object before using it.