apolloconfig / agollo

🚀Go client for ctrip/apollo (https://github.com/apolloconfig/apollo)
https://www.apolloconfig.com
Apache License 2.0
708 stars 189 forks source link

Failfast for explicit error http request instead of retrying (#296) #297

Closed larry4xie closed 9 months ago

larry4xie commented 9 months ago

296

mergify[bot] commented 9 months ago

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

nobodyiam commented 9 months ago

Fantastic work! Could we incorporate some unit tests to ensure coverage of the newly implemented logic?

larry4xie commented 9 months ago

@nobodyiam Unit tests 已提交(module protocol/http coverage: 61.4% > 69.3%)

image

nobodyiam commented 9 months ago

Looks like we need to also fix other test cases.

image
larry4xie commented 9 months ago

@nobodyiam fixed, and successfully ran all test cases

image