apolloconfig / agollo

🚀Go client for ctrip/apollo (https://github.com/apolloconfig/apollo)
https://www.apolloconfig.com
Apache License 2.0
708 stars 189 forks source link

Make hash function in signature settable #299

Closed nanjj closed 6 months ago

nanjj commented 8 months ago

In case apollo server using sha256 hash function as signature, the signature function can support also.

mergify[bot] commented 8 months ago

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

nobodyiam commented 8 months ago

This is an interesting proposal, however, t's hard to envision a scenario where apollo server would change the signature function any time soon...

nanjj commented 8 months ago

This is an interesting proposal, however, t's hard to envision a scenario where apollo server would change the signature function any time soon...

Suppose user changed https://github.com/apolloconfig/apollo-java/blob/07ed79b06859202a8e7df6fd007168182417df0c/apollo-core/src/main/java/com/ctrip/framework/apollo/core/signature/Signature.java#L40, and packaged apollo server, the apollo java client would work OK, while the agollo would not.