fix: 如果获取不到config，尝试远端同步获取一次，获取到的内容需要更新缓存

qdsordinarydream commented 7 months ago

在获取不到 config 配置的时候，没有将远端获取的内容更新到本地缓存，让查询变得无意义

Summary by CodeRabbit

Refactor
- Improved error handling in configuration initialization.
- Updated cache updating mechanism for better synchronization.
Documentation
- Enhanced comments for better clarity on exported functions and interfaces.
Style
- Adjusted naming conventions for more intuitive function names.
Tests
- Added new test functions utilizing gomonkey for mocking.

coderabbitai[bot] commented 7 months ago

Walkthrough

The updates to the client code encompass improvements in documentation, error handling, and caching mechanisms in client.go. Renamed functions adhere to better conventions, enhancing usability and clarity. These changes collectively aim to refine the client interface for better user experience and reliability.

Changes

File(s)	Summary of Changes
`client.go`	- Enhanced documentation comments - Added error handling in `GetConfigAndInit` - Modified `SyncWithNamespace` for cache update - Renamed exported functions for consistency
`client_test.go`	- Added `reflect` import - Imported `github.com/agiledragon/gomonkey/v2` and `github.com/apolloconfig/agollo/v4/component/remote` - Modified `init` function declaration - Added new test functions utilizing `gomonkey` for mocking

🐇✨
Changes here, changes there,
Code refined with utmost care.
Comments clear, errors caught,
Naming fixed, just as thought.
In the cache, updates gleam,
A coderabbit's dreamy dream. 🌟
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

mergify[bot] commented 7 months ago

感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8166509762

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 74.468%

Totals
Change from base Build 5706641819:	0.3%
Covered Lines:	1295
Relevant Lines:	1739

💛 - Coveralls

nobodyiam commented 7 months ago

This looks like a bug that the local cache is not updated. Would you please help to write a unit test so that this logic could be covered?

qdsordinarydream commented 7 months ago

增加：去除同方法内 cache init 步骤，同理没有赋值并没有意义，且在 UpdateApolloConfig 步骤中，会有 cache store 的步骤

apolloconfig / agollo