search

apolloconfig / agollo

🚀Go client for ctrip/apollo (https://github.com/apolloconfig/apollo)
https://www.apolloconfig.com
Apache License 2.0
708 stars 189 forks source link

fix: 触发懒加载时，需要同步更新notify内容，更新component监听变更的ns #302

Closed qdsordinarydream closed 6 months ago

qdsordinarydream commented 7 months ago

触发懒加载时，需要同步更新notify内容，更新component监听变更的ns；因为sync也会触发component返回，所以component不需要重新 start，期间两秒的时间足够configComponent变更appconfig

component 依赖 appconfig 的内容更新 image image image

Summary by CodeRabbit

coderabbitai[bot] commented 7 months ago

Walkthrough

The recent updates focus on refining the configuration management and testing within a Go project. Modifications include variable name corrections, enhanced logic for configuration retrieval and caching, and updates to app configuration handling. Additionally, test coverage has been expanded to ensure the updated configuration logic functions as expected, particularly with regards to application notifications and cache coherence.

Changes

File(s) Summary
client.go Corrected variable names, updated configuration retrieval and caching logic, added string operations.
client_test.go Added assertion for appConfig notifications map update, included cache update comment, and updated imports.
.../notify/componet_notify_test.go Added a test for SetAppConfig method to ensure correct application configuration updates.

"In the realm of code, where logic is king,
🐰 A rabbit hopped in, making changes with a swing.
Renaming, testing, with a meticulous eye,
Ensuring configs are right, under the digital sky.
With every hop, a bug squashed, making the codebase sing,
This rabbit coder, with joy, does bring."
🌟🌈🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
mergify[bot] commented 7 months ago

感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8433294733

Details

Totals Coverage Status
Change from base Build 8181144278: 0.4%
Covered Lines: 1313
Relevant Lines: 1754
💛 - Coveralls
nobodyiam commented 6 months ago

Could you assist in including a test case that this pull request resolves?

qdsordinarydream commented 6 months ago

Could you assist in including a test case that this pull request resolves?

sure, completed

nobodyiam commented 6 months ago

Could you assist in including a test case that this pull request resolves?

sure, completed

Thank you! Could you also assist in addressing the concerns mentioned by @coderabbitai?

coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

It appears there was a misunderstanding. The output provided does not contain specific concerns raised by @coderabbitai within the context of the PR comments. Instead, it outlines general instructions on how to interact with @coderabbitai in PR comments and the capabilities offered. Given this, there are no direct concerns from @coderabbitai to address based on the provided script output.

If there are specific areas of the code or aspects of the PR you would like feedback on, please provide more details or direct me to specific comments or code changes in the PR. I'm here to assist with code review, answer questions, or provide guidance on specific tasks as needed.

Analysis chain
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Search for comments made by @coderabbitai in the PR to identify the concerns. gh pr view 302 --repo apolloconfig/agollo --comments | grep -A 5 "@coderabbitai" ``` Length of output: 2113
zouyx commented 6 months ago

I need more time to test this feature before release.