apolloconfig / apollo-java

Apollo Java Clients
Apache License 2.0
40 stars 72 forks source link

feat(openapi): create app (#32) #44

Closed ThugJudy closed 1 year ago

ThugJudy commented 1 year ago

What's the purpose of this PR

Fix the test case com.ctrip.framework.apollo.openapi.client.service.ItemOpenApiServiceTest.testFindItemsByNamespace

Which issue(s) this PR fixes:

Fixes #43

Brief changelog

I propose using a LinkedHashMap, so that the order in which the params are inserted is preserved and flakiness is resolved. https://github.com/ThugJudy/apollo-java/blob/d8e4352ff8c9e9c6fc37961c49d4b7018b47fc14/apollo-openapi/src/main/java/com/ctrip/framework/apollo/openapi/client/url/OpenApiPathBuilder.java#L64

Follow this checklist to help us incorporate your contribution quickly and easily:

codecov[bot] commented 1 year ago

Codecov Report

Merging #44 (d8e4352) into main (5344bc4) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #44   +/-   ##
=========================================
  Coverage     68.59%   68.59%           
  Complexity     1206     1206           
=========================================
  Files           171      171           
  Lines          5196     5196           
  Branches        561      561           
=========================================
  Hits           3564     3564           
  Misses         1371     1371           
  Partials        261      261           
Files Coverage Δ
.../apollo/openapi/client/url/OpenApiPathBuilder.java 96.49% <100.00%> (ø)