Closed Anilople closed 5 months ago
The updates enhance the Apollo Java client by optimizing the startup process, particularly when encountering timeouts. Key changes include improvements in HTTP request handling, task submission control, and configuration updates, significantly reducing the time taken to load namespaces under error conditions.
Files/Modules | Change Summary |
---|---|
ConfigServiceLocator.java |
Enhanced initialization, added timeout configuration, task submission control, and rate limiting. |
ConfigUtil.java |
Added new configuration fields and refactored methods to include timeout settings. |
BaseIntegrationTest.java |
Updated imports, logger declaration, and added methods for file operations and configuration assembly. |
MockedConfigService.java |
Added constant and method for simulating timeout. |
ConfigServiceLocatorTest.java |
Updated imports and test methods, added new test for exception handling. |
RemoteConfigRepositoryTest.java |
Removed calls to remoteConfigLongPollService.stopLongPollingRefresh() from various test methods. |
CHANGES.md |
Documented performance enhancement for handling timeouts during startup. |
sequenceDiagram
participant Client
participant ConfigServiceLocator
participant ExecutorService
participant ConfigUtil
participant RemoteConfigService
Client->>ConfigServiceLocator: Initialize
ConfigServiceLocator->>ConfigUtil: Get timeout settings
ConfigServiceLocator->>ExecutorService: Submit update task
ExecutorService->>RemoteConfigService: Fetch config services
RemoteConfigService-->>ExecutorService: Response
ExecutorService-->>ConfigServiceLocator: Update config services
ConfigServiceLocator-->>Client: Return config services
Objective | Addressed | Explanation |
---|---|---|
Speed up user's startup time (Issue #60) | ✅ |
In the land of Apollo, where configs flow, Startup's swift, no more slow. With timeouts tamed and tasks in line, Our client shines, truly divine. Fast and bright, like a comet's flight, Apollo's updates bring delight. 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What's the purpose of this PR
Speed up when startup meet timeout, i.e when meet meta service and config service crash.
Which issue(s) this PR fixes:
Fixes #60
Brief changelog
There is a synchronized lock in
https://github.com/apolloconfig/apollo-java/blob/3f0979da3ea6478304719a71d4991fe4787558d1/apollo-client/src/main/java/com/ctrip/framework/apollo/internals/ConfigServiceLocator.java#L193
It will block even use multiple thread.
When try to getConfigServices, if cache is empty, method
updateConfigServices
will be invokehttps://github.com/apolloconfig/apollo-java/blob/3f0979da3ea6478304719a71d4991fe4787558d1/apollo-client/src/main/java/com/ctrip/framework/apollo/internals/ConfigServiceLocator.java#L162-L167
In this pr, the code change to fail quickly, so it can speed up when meta service and config service crash(that will cause timeout for client).
Maybe it better to let daemon thread to invoke method
updateConfigServices
, another thread just use the result in memory cache, If there is no available config service, throw exception quickly.After change, load 10 namespaces timeusage from 65929 ms to 5150ms when all of them meet timeout
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation