search

apolloconfig / apollo-use-cases

Show various usage scenarios and sample codes of the Apollo configuration center, welcome to share more configuration use cases in your daily work!
Apache License 2.0
945 stars 401 forks source link

Remove unused dependencies #39

Closed Celebrate-future closed 3 years ago

Celebrate-future commented 3 years ago

@nobodyiam Hi, I am a user of project com.ctrip.framework.apollo:app:1.0-SNAPSHOT. I found that its pom file introduced 26 dependencies. However, among them, 9 libraries (34%) have not been used by your project (the redundant dependencies are listed below). This PR helps com.ctrip.framework.apollo:app:1.0-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

Redundant dependencies----


org.springframework.boot:spring-boot-starter-logging:jar:2.0.3.RELEASE:compile
aopalliance:aopalliance:jar:1.0:compile
ch.qos.logback:logback-core:jar:1.2.3:compile
ch.qos.logback:logback-classic:jar:1.2.3:compile
org.apache.logging.log4j:log4j-api:jar:2.10.0:compile
javax.annotation:javax.annotation-api:jar:1.3.2:compile
javax.inject:javax.inject:jar:1:compile
org.apache.logging.log4j:log4j-to-slf4j:jar:2.10.0:compile
org.slf4j:jul-to-slf4j:jar:1.7.25:compile
nobodyiam commented 3 years ago

This is only a demo project so I think it's not a big deal to have some unused dependencies.

Celebrate-future commented 3 years ago

@nobodyiam thanks for your feedback.