search

apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.17k stars 10.21k forks source link

Add github action google-java-format or not #4196

Open Anilople opened 2 years ago

Anilople commented 2 years ago

Is your feature request related to a problem? Please describe. Now the java code's format use google style, but sometime a contributor maybe forget format the code.

Describe the solution you'd like There is a github action Google Java Format https://github.com/marketplace/actions/google-java-format

This action can help us format the java code before pr merged.

Do we need to use it?

Additional context The historical java code maybe be formated too, need more investigation

nobodyiam commented 2 years ago

This sounds a good idea to me. We may submit a standalone pr to format the current codes first.