apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.08k stars 10.2k forks source link

Fix audit log bugs #5006

Closed BlackBear2003 closed 10 months ago

BlackBear2003 commented 11 months ago

What's the purpose of this PR

Fix the serious bug which I left on last PR https://github.com/apolloconfig/apollo/pull/4985

Which issue(s) this PR fixes:

Fixes # https://github.com/apolloconfig/apollo/pull/4985

Brief changelog

Fixed some incorrect method parameter calls, fixed some issues with the front-end interface.

Follow this checklist to help us incorporate your contribution quickly and easily:

codecov[bot] commented 11 months ago

Codecov Report

Merging #5006 (776e632) into master (bc55ba6) will increase coverage by 0.03%. The diff coverage is 11.11%.

@@             Coverage Diff              @@
##             master    #5006      +/-   ##
============================================
+ Coverage     49.27%   49.30%   +0.03%     
- Complexity     1889     1893       +4     
============================================
  Files           372      372              
  Lines         11538    11544       +6     
  Branches       1123     1126       +3     
============================================
+ Hits           5685     5692       +7     
+ Misses         5513     5512       -1     
  Partials        340      340              
Files Coverage Δ
...ollo/audit/component/ApolloAuditLogApiJpaImpl.java 83.60% <33.33%> (-2.84%) :arrow_down:
...mework/apollo/audit/aop/ApolloAuditSpanAspect.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

BlackBear2003 commented 11 months ago

This bug has been fixed well, could this pr be merged?

@Anilople

Anilople commented 10 months ago

Add some tests?

image

BlackBear2003 commented 10 months ago

Add some tests?

image

added on #5008