apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.08k stars 10.2k forks source link

support send email with SMTPSSLTransport #5018

Closed dongqiaoershao closed 8 months ago

dongqiaoershao commented 10 months ago

接入邮件服务发现只支持smtp(25端口),不支持smtps(465端口),估计可能会有一些使用者遇到类似的问题,故提个PR增加支持ssl方式,代码写得有点粗糙,希望该意见能得到采纳,感谢不吝赐教。

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

codecov[bot] commented 10 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (bc55ba6) 49.27% compared to head (2c0fe61) 49.48%. Report is 11 commits behind head on master.

Files Patch % Lines
...lo/portal/spi/defaultimpl/DefaultEmailService.java 0.00% 17 Missing :warning:
...ollo/audit/component/ApolloAuditLogApiJpaImpl.java 33.33% 1 Missing and 1 partial :warning:
...mework/apollo/audit/aop/ApolloAuditSpanAspect.java 96.87% 0 Missing and 1 partial :warning:
...k/apollo/portal/component/config/PortalConfig.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5018 +/- ## ============================================ + Coverage 49.27% 49.48% +0.20% - Complexity 1889 1902 +13 ============================================ Files 372 372 Lines 11538 11564 +26 Branches 1123 1129 +6 ============================================ + Hits 5685 5722 +37 + Misses 5513 5502 -11 Partials 340 340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nobodyiam commented 10 months ago

By the way, please sign the Contributor License Agreement (CLA) as instructed by the CLA Assistant.

dongqiaoershao commented 10 months ago

I have read the CLA Document and I hereby sign the CLA

stale[bot] commented 9 months ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale[bot] commented 8 months ago

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!