search

apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.08k stars 10.2k forks source link

Solved some implementation and design smells #5023

Closed gunjanVazirani closed 8 months ago

gunjanVazirani commented 10 months ago

What's the purpose of this PR

Have solved 3 design smells and 3 implementation smells as a part of our assignment

Which issue(s) this PR fixes:

Fixes # It resolves design smells and implementation smells in different sections of the code.

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

stale[bot] commented 9 months ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale[bot] commented 8 months ago

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!