Closed vdiskg closed 5 months ago
Attention: 240 lines
in your changes are missing coverage. Please review.
Comparison is base (
921af84
) 49.65% compared to head (e8b44ee
) 50.38%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Wow! This pr is truly thrilling!
It appears there is some incompatibility with database-discovery. When I execute the assembly using the spring profiles github,auth,database-discovery
, only the apollo-configservice gets registered.
This is very impressive! I really like the click-and-go experience to start the apollo service with no extra setup.
Below are some comments for your review:
demo.sh
for starting/stopping the services. However, we can address this in a separate pull request since it involves modifications to demo.sh
itself.Caused by: org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "Favorite" not found; SQL statement:
Update Favorite set IsDeleted = true, DeletedAt = ROUND(UNIX_TIMESTAMP(NOW(4))*1000) where Id = ? [42102-214]
Caused by: org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "InstanceConfig" not found; SQL statement:
select b.Id from InstanceConfig a inner join Instance b on b.Id = a.`InstanceId` where a.`ConfigAppId` = ? and a.`ConfigClusterName` = ? and a.`ConfigNamespaceName` = ? and a.`DataChange_LastTime` > ? and b.`AppId` = ? limit ? [42102-214]
Caused by: org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "GrayReleaseRule" not found; SQL statement:
Update GrayReleaseRule set IsDeleted = true, DeletedAt = ROUND(UNIX_TIMESTAMP(NOW(4))*1000) where Id = ? [42102-214]
I'm considering the possibility of connecting our assembly application to two separate databases. This approach could simplify a lot by eliminating the need to rename table names. It involves establishing two distinct data sources, as outlined in this guide on Spring Data JPA with Multiple Databases.
This pull request appears to be in good shape now. Could you also update the CHANGES.md file? Since this constitutes a major change, it's important to document it there.
BTW, #5072 was merged with a schema change, would you please help to update the code base again?
What's the purpose of this PR
Which issue(s) this PR fixes:
4313
4729
Brief changelog
TablePrefixNamingStrategy
to match the table name prefixFollow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.