search

apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
28.94k stars 10.19k forks source link

Fix circular references on LdapAutoConfiguration #5055

Closed BlackBear2003 closed 6 months ago

BlackBear2003 commented 6 months ago

What's the purpose of this PR

Fix circular references on LdapAutoConfiguration

Which issue(s) this PR fixes:

Fixes #https://github.com/apolloconfig/apollo/issues/5051

Brief changelog

Update SpringSecurityLDAPAuthAutoConfiguration

Follow this checklist to help us incorporate your contribution quickly and easily:

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76ec52d) 49.62% compared to head (33b9ab7) 49.62%.

Files Patch % Lines
...lo/portal/spi/configuration/AuthConfiguration.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5055 +/- ## ========================================= Coverage 49.62% 49.62% Complexity 1904 1904 ========================================= Files 372 372 Lines 11559 11558 -1 Branches 1127 1127 ========================================= Hits 5736 5736 + Misses 5483 5482 -1 Partials 340 340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BlackBear2003 commented 6 months ago

Can I not write test code for this PR please?🥺

nobodyiam commented 6 months ago

Considering the findings presented in report #5056, I believe it is reasonable to forego the creation of unit tests. Would you please also update the CHANGES.md? I think it's valuable to let users know the fix.

BlackBear2003 commented 6 months ago

Considering the findings presented in report #5056, I believe it is reasonable to forego the creation of unit tests. Would you please also update the CHANGES.md? I think it's valuable to let users know the fix.

Am I update on the right CHANGES file?