Closed BlackBear2003 closed 5 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
6657a58
) 49.65% compared to head (8db44fa
) 49.60%.
Files | Patch % | Lines |
---|---|---|
...com/ctrip/framework/apollo/biz/entity/Cluster.java | 0.00% | 4 Missing :warning: |
.../ctrip/framework/apollo/common/dto/ClusterDTO.java | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks great! Please find some comments below:
I think the comment is similar to the remarks
of namespace, so it's better to use the same term, e.g. Remarks
and 备注
I think the comment should not be mandatory, as it's not a necessary information
When displaying the comment, it's not necessary to display the prefix comment:
I think the comment is similar to the remarks of namespace, so it's better to use the same term, e.g. Remarks and 备注
changed terms at front-end from 'comment' to 'remarks'.
I'm not sure should we change the sql and entity's field name? I see there is comment
in AppNamespace, Commit and Item while there is not remarks
. So I just use remark
when UI display.
What's the purpose of this PR
Add comment for clusters and UI display
Which issue(s) this PR fixes:
Fixes #https://github.com/apolloconfig/apollo/issues/5067
Brief changelog
it looks like:
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.