Fix the issue that the length of private namespaces are mis-calculated

apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.

Apache License 2.0

28.94k stars 10.19k forks source link

What's the purpose of this PR

Fix the issue that the length of private namespaces are mis-calculated

Which issue(s) this PR fixes:

Fixes #5073

Brief changelog

Fix the logic of shouldAppendNamespacePrefix

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[x] Update the CHANGES log.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0c21659) 49.60% compared to head (c6a84b4) 49.60%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5078 +/- ## ========================================= Coverage 49.60% 49.60% Complexity 1904 1904 ========================================= Files 372 372 Lines 11564 11564 Branches 1127 1127 ========================================= Hits 5736 5736 Misses 5488 5488 Partials 340 340 ```

apolloconfig / apollo