coderabbitai[bot]
commented
6 months ago Walkthrough
Version 2.3.0 of Apollo addresses a critical issue with role permission deletions when appid contains an underscore (_). The changes primarily involve modifying query conditions in repository classes to use LIKE instead of = and escaping underscores in appid to prevent misinterpretation in MySQL queries.
Changes
| File Path | Change Summary |
|---|---|
CHANGES.md |
Documented the fix for role permission deletion issue with appid containing underscores. |
.../repository/PermissionRepository.java |
Modified query conditions to use LIKE instead of = for targetId and added additional conditions. |
.../repository/RoleRepository.java |
Changed query conditions to use LIKE instead of direct equality comparisons for role names. |
.../spi/defaultimpl/DefaultRolePermissionService.java |
Added import for EscapeCharacter and modified methods to escape appid using EscapeCharacter.DEFAULT.escape(appId). |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Fix role permission deletion issue when appid contains an underscore (_) (#5143) |
✅ |
In fields where underscores lie, Permissions now won't go awry. With
LIKEand escape in place, Apollo's roles keep their grace. Bugs fixed, the code refined, Peace of mind, you'll surely find.
[!TIP]
New Features and Improvements
## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What's the purpose of this PR
Fix the role permission deletion issue when appid contains '_'
Which issue(s) this PR fixes:
Fixes #5143
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit
Bug Fixes
appidcontaining underscores (_).Improvements
LIKEinstead of=fortargetIdand role names.appidby escaping underscores for more accurate query results.