Closed Anilople closed 5 months ago
In version 2.3.0 of Apollo, a fix was introduced to ensure the -XX:HeapDumpPath
is ready when encountering an OutOfMemory error. This involved updating startup scripts across various services to create a necessary directory under the $LOG_DIR
.
Files/Paths | Change Summary |
---|---|
CHANGES.md |
Added a summary of the fix for -XX:HeapDumpPath readiness on OutOfMemory error. |
apollo-adminservice/src/main/scripts/startup.sh , apollo-configservice/src/main/scripts/startup.sh , apollo-portal/src/main/scripts/startup.sh |
Added commands to create HeapDumpOnOutOfMemoryError directory under $LOG_DIR in startup scripts. |
In Apollo's code, a change so bright,
To handle memory's darkest night.
Directories made with scripts so neat,
Ensuring dumps land on their feet.
Version two-three-oh, we cheer,
For smoother runs, no need to fear.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What's the purpose of this PR
fix scripts/
startup.sh
Which issue(s) this PR fixes:
Brief changelog
When meet OOM, the .hprof file should auto dump, but the directory not ready, so meet some error.
This pr prepare the directory for OOM when startup.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit
Bug Fixes
-XX:HeapDumpPath
was not ready when encountering an OutOfMemory error.Chores
HeapDumpOnOutOfMemoryError
directory under the existing log directory.