feat: support portal restTemplate Client connection pool config

youngzil commented 3 months ago

What's the purpose of this PR

Portal 模块 RestTemplate 支持配置 HTTP最大连接池和每个路由的连接大小详见 #5199

Which issue(s) this PR fixes:

Fixes #5199

Brief changelog

support portal restTemplate Client connection pool config

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[x] Update the CHANGES log.

Summary by CodeRabbit

New Features
- Added support for configuring a connection pool for the HTTP client, enhancing performance and efficiency in handling multiple connections.
- Introduced new configuration methods to manage connection pooling parameters.
Documentation
- Updated changelog to reflect the addition of connection pool configuration support for the HTTP client.

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes enhance the RestTemplateFactory and PortalConfig classes by integrating a connection management feature, allowing configuration of the maximum connection pool and connections per route for HTTP requests. This optimization aims to improve performance and resource management, addressing limitations observed during high-load scenarios in the Apollo portal.

Changes

File Path	Change Summary
`apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/RestTemplateFactory.java`	Implemented a `PoolingHttpClientConnectionManager` to optimize HTTP connection management.
`apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/config/PortalConfig.java`	Added `connectPoolMaxTotal()` and `connectPoolMaxPerRoute()` methods for customizable connection settings.
`CHANGES.md`	Documented the new feature supporting connection pool configuration for the `RestTemplate` client.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PortalConfig
    participant RestTemplateFactory
    participant ConnectionManager

    User->>PortalConfig: Request config values
    PortalConfig-->>User: Return connectPoolMaxTotal() and connectPoolMaxPerRoute()
    User->>RestTemplateFactory: Create RestTemplate with config
    RestTemplateFactory->>ConnectionManager: Set connection limits
    ConnectionManager-->>RestTemplateFactory: Connection pool ready

Assessment against linked issues

Objective	Addressed	Explanation
Support configuration of HTTP max connection pool and per route size (#5199)	✅
Resolve high load performance issues by optimizing connection management	✅

Poem

🐰 In the portal where bunnies hop,
New connections bloom, never stop!
Pooling brings joy, in a swift ballet,
HTTP flows free, come what may!
Hooray for the changes, let’s cheer and play! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

nobodyiam commented 3 months ago

Please complete the CLA by following the instructions provided by the CLA bot. Once done, you may proceed to refresh the codebase and update the CHANGES.md file.

youngzil commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

apolloconfig / apollo