search

apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.18k stars 10.21k forks source link

fix：RefreshAdminServerAddressTask supports dynamic configuration of time interval #5248

Closed youngzil closed 1 month ago

youngzil commented 1 month ago

…ime interval

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #5245

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve modifications to the AdminServiceAddressLocator and PortalConfig classes within the Apollo portal. The AdminServiceAddressLocator class now includes a new dependency on PortalConfig, which allows for dynamic configuration of refresh intervals for admin server address tasks. The previous hardcoded constants for refresh intervals have been removed and replaced with method calls to PortalConfig. The PortalConfig class has been updated to include new methods for retrieving these intervals, along with validation logic for ensuring the values are within acceptable bounds.

Changes

File Change Summary
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/AdminServiceAddressLocator.java - Constructor updated to include PortalConfig.
- Removed constants NORMAL_REFRESH_INTERVAL and OFFLINE_REFRESH_INTERVAL.
- Replaced with method calls to portalConfig.
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/config/PortalConfig.java - Added methods refreshAdminServerAddressTaskNormalIntervalSecond() and refreshAdminServerAddressTaskOfflineIntervalSecond().
- Introduced validation method checkInt().
- Added constants for default refresh intervals.
CHANGES.md - Updated to reflect Apollo version 2.4.0 release notes, highlighting dynamic configuration for RefreshAdminServerAddressTask.

Assessment against linked issues

Objective Addressed Explanation
Dynamic adjustment of RefreshAdminServerAddressTask delay time (#5245) ✅

Possibly related PRs

Suggested labels

lgtm

Poem

In the land of code where rabbits play,
New settings bloom, brightening the day.
Refresh intervals now dance with grace,
Configurable paths in a dynamic space.
Hopping along, we cheer and sing,
For changes like these make our hearts spring! 🐇✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between b96466bfc3c8606a6f87a4ba4bd4d2ad0c1eb89f and 9b0bc5c3c19aeb69eb2077be932e2589af100254.
📒 Files selected for processing (1) * CHANGES.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * CHANGES.md
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
youngzil commented 1 month ago

@nobodyiam I have solved these problems, please review again

nobodyiam commented 1 month ago

Please help to solve the conflicts in CHANGES.md

youngzil commented 1 month ago

Please help to solve the conflicts in CHANGES.md

@nobodyiam I have resolved this conflict, please help review it again