search

apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.18k stars 10.21k forks source link

refactor(sql): align database ClusterName and NamespaceName fields lengths #5263

Closed youngzil closed 2 weeks ago

youngzil commented 3 weeks ago

What's the purpose of this PR

Update the Commit, Namespace, and Release table structures: modify the ClusterName and NamespaceName fields to VARCHAR(32)

Which issue(s) this PR fixes:

Fixes #5259

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits Reviewing files that changed from the base of the PR and between 320653210db08d0d5ec3cded12901f47e5b34396 and 0dc3da416b2d32a972b1122ce0c0c9633e6e9bfd.
📒 Files selected for processing (1) * `CHANGES.md` (1 hunks) 
 __________________________
< // TODO: Find more bugs. >
 --------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Walkthrough

The pull request introduces several updates and enhancements to the Apollo configuration database schema as part of version 2.4.0. Key changes include the standardization of the lengths of ClusterName and NamespaceName fields across multiple tables, reducing their maximum length from varchar(500) to varchar(32). Additionally, a new Mode column has been added to the AccessKey table, and various fixes have been implemented to address issues such as duplicate comments and missing items in published namespaces.

Changes

File Path Change Summary
CHANGES.md Updated to reflect new features, enhancements, and fixes in version 2.4.0, including global search functionality and connection pool configuration improvements.
scripts/sql/profiles/h2-default/apolloconfigdb.sql Altered data types for ClusterName and NamespaceName columns from varchar(500) to varchar(32) in multiple tables.
scripts/sql/profiles/h2-default/delta/v230-v240/apolloconfigdb-v230-v240.sql Added Mode column to AccessKey table and modified ClusterName and NamespaceName columns in several tables to VARCHAR(32) NOT NULL DEFAULT 'default'.
scripts/sql/profiles/mysql-database-not-specified/apolloconfigdb.sql Similar changes as above, updating column types from varchar(500) to varchar(32) for consistency across multiple tables.
scripts/sql/profiles/mysql-database-not-specified/delta/v230-v240/apolloconfigdb-v230-v240.sql Included new Mode column in AccessKey and modified column types in Commit, Namespace, and Release tables to VARCHAR(32) NOT NULL DEFAULT 'default'.
scripts/sql/profiles/mysql-default/apolloconfigdb.sql Consistent updates to column types from varchar(500) to varchar(32) for various tables, maintaining the overall structure.
scripts/sql/profiles/mysql-default/delta/v230-v240/apolloconfigdb-v230-v240.sql Added Mode column to AccessKey and modified column types in Commit, Namespace, and Release tables to VARCHAR(32) NOT NULL DEFAULT 'default'.
scripts/sql/src/apolloconfigdb.sql Updated column types for ClusterName and NamespaceName in multiple tables from varchar(500) to varchar(32), and modified Comment column length in Release table.
scripts/sql/src/delta/v230-v240/apolloconfigdb-v230-v240.sql Added Mode column to AccessKey and ensured ClusterName and NamespaceName columns in Commit, Namespace, and Release tables are VARCHAR(32) NOT NULL DEFAULT 'default'.

Assessment against linked issues

Objective Addressed Explanation
Standardize lengths of ClusterName and NamespaceName fields across tables (#5259) ✅

Possibly related PRs

Suggested labels

size:M, lgtm

Suggested reviewers

🐰 In the garden where changes bloom,
The fields are trimmed, no more gloom.
With names now short, and modes anew,
Apollo shines, a brighter view!
Hopping forward, we refine,
In every line, our code will shine! 🌼

[!TIP]

You can customize the tone of the review comments and chat replies. Set the `tone_instructions` setting in your project's settings in CodeRabbit to customize the tone of the review comments and chat replies. For example, you can set the tone to `Act like a strict teacher`, `Act like a pirate` and more.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.20%. Comparing base (f55b419) to head (7829654). Report is 15 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5263 +/- ## ============================================ + Coverage 50.30% 51.20% +0.90% - Complexity 2013 2097 +84 ============================================ Files 388 393 +5 Lines 12228 12438 +210 Branches 1209 1229 +20 ============================================ + Hits 6151 6369 +218 + Misses 5712 5681 -31 - Partials 365 388 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.