apolloconfig / apollo

Apollo is a reliable configuration management system suitable for microservice configuration management scenarios.
https://www.apolloconfig.com
Apache License 2.0
29.18k stars 10.21k forks source link

feat(biz): Added the value length limit function for AppId-level configuration items #5264

Closed youngzil closed 2 weeks ago

youngzil commented 3 weeks ago

What's the purpose of this PR

Which issue(s) this PR fixes:

Fixes #5254

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

Summary by CodeRabbit

Release Notes for Apollo Version 2.4.0

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes introduced in this pull request encompass enhancements to the Apollo Configuration Center, including the addition of a value length limit function for AppId-level configuration items. Updates include improved server configuration links, REST template client connection pooling, and global search capabilities for administrators. Several fixes address issues with duplicate comments and blank lines. The modifications also enhance the BizConfig and ItemService classes to better manage namespace and AppId configurations, alongside updates to documentation for clearer deployment instructions.

Changes

File Change Summary
CHANGES.md Added entry for new feature on value length limit for AppId-level configurations, updated server configuration links, and documented several fixes and enhancements.
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/config/BizConfig.java Added methods for AppId and namespace value length limit overrides, removed an existing method for namespace limits, and introduced a static type reference for deserialization.
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/service/ItemService.java Updated methods to use Namespace objects instead of long IDs for item value length checks, enhancing clarity and efficiency.
apollo-biz/src/test/java/com/ctrip/framework/apollo/biz/config/BizConfigTest.java Added new test for appIdValueLengthLimitOverride method, including various input scenarios and error handling.
apollo-biz/src/test/java/com/ctrip/framework/apollo/biz/service/ItemServiceTest.java Enhanced test setup with additional dependencies, modified existing tests, and added new tests for item saving with value length limit overrides.
docs/en/deployment/distributed-deployment-guide.md Updated deployment guide with detailed configuration instructions, including MySQL version requirements and Docker/Kubernetes deployment examples.
docs/zh/deployment/distributed-deployment-guide.md Similar updates to the Chinese version of the deployment guide, enhancing clarity and detail on deployment processes and configurations.

Assessment against linked issues

Objective Addressed Explanation
Provide AppId-level parameter to skip value length checks (#5254)
Enhance configuration management for value length limits (#5254)

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

Poem

🐇 In the garden where configs grow,
Length limits now set to flow.
AppId whispers, "Let me be free,"
With namespaces dancing in harmony.
Updates and fixes, all in a row,
Apollo's magic, watch it glow! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.