search

apollodao / cw-dex

CosmWasm abstractions for decentralized exchanges.
Mozilla Public License 2.0
5 stars 4 forks source link

picasso #145

Closed dzmitry-lahoda closed 6 months ago

dzmitry-lahoda commented 1 year ago

Hey @dzmitry-lahoda ! Thanks a lot for your PR. I am not familiar with Picasso only had a quick look here. I hope that is the correct picasso. I have a few general questions

  • Is there any way of integration testing the implementation against a Picasso instance? Either running locally in a docker container or preferably something like osmosis test-tube?
  • Does this implement interaction with the PabloDEX?
  • Will the contract address and messaging change in the future? In that case maybe we should consider maintaining the messages as well as the const address in a separate crate

Also, is the source of the DEX somewhere?

yes. that dex. we are dotsama, not cosmos, so cosmos tooling does not work with us. testing like this https://github.com/ComposableFi/composable/blob/main/code/parachain/frame/cosmwasm/cli/README.md

i may end up testing if will use cw dex for our cross chain swaps with osmosis and others. i hope for shared dex interface to simplfiy https://github.com/ComposableFi/composable/blob/main/code/xcvm/SPEC.md

until cw 2 with no std support, any crate we produce are not compatible in compile time with ci of cosmos people. in september 2023 if cw 2 will merge no std we will produce crate. address wil never change as it is module address really, not co tract at all. messages are 100% same as dotsama, i doubt these will change in incompatible way any time soon. we have dex for half year in prod.

source of dex https://github.com/ComposableFi/composable/blob/main/code/parachain/pablo

dzmitry-lahoda commented 1 year ago

unrelated deny fails. linting to fix.

pacmanifold commented 1 year ago

hey @dzmitry-lahoda ! sorry for a slow response. very busy this week with some final stuff before one week vacation. I'll be back around 2nd of Aug. I really need to read up a bit more on Dotsama. Would love to take a quick call and discuss how you plan on using the cw-dex implementation and what would be needed from our side for our contracts to support Composable.