search

apollodao / cw-dex

CosmWasm abstractions for decentralized exchanges.
Mozilla Public License 2.0
5 stars 4 forks source link

Get Astroport to use upstream cw-asset or implement From trait #39

Closed apollo-sturdy closed 2 years ago

apollo-sturdy commented 2 years ago 
    Do we know why Astroport uses a fork of cw-asset? Can we get them to use upstream or implement From or Into traits?

_Originally posted by @apollo-sturdy in https://github.com/apollodao/cw-dex/pull/10#discussion_r1015576643_

apollo-sturdy commented 2 years ago

Remove the newtype and just import astroport asset as AstroAsset or whatever https://github.com/apollodao/cw-dex/blob/master/src/implementations/astroport/helpers.rs#L18

apollo-sturdy commented 2 years ago

Not relevant anymore since we created our own fork of cw-asset.