search

apollographql / apollo-client-devtools

Apollo Client browser developer tools.
https://apollographql.com/docs/react/development-testing/developer-tooling/#apollo-client-devtools
MIT License
1.5k stars 166 forks source link

Breaks Support for Import Maps #464

Closed guybedford closed 1 year ago

guybedford commented 3 years ago

Intended outcome: It should be possible to use apollo client devtools on websites that use import maps.

Actual outcome: Because Apollo Client Devtools injects ES modules into the page, this causes all subsequent import maps in the page to not be processed, giving the import map error - An import map is added after module script load was triggered.

I've posted more information about this in https://github.com/WICG/import-maps/issues/248.

How to reproduce the issue: For example, try navigating to https://generator.jspm.io/ with the extension enabled in latest chrome with import maps support (89+). The error above comes up and the page will not load further unless the extension is disabled.

Desktop (please complete the following information):

hwillson commented 3 years ago

Interesting - thanks @guybedford. We'll take a look!