search

apollographql / apollo-client-nextjs

Apollo Client support for the Next.js App Router
https://www.npmjs.com/package/@apollo/experimental-nextjs-app-support
MIT License
358 stars 25 forks source link

separate transport-specific streaming logic out #189

Closed phryneas closed 2 months ago

phryneas commented 3 months ago

See a lot of comments further down :)

phryneas commented 3 months ago

/release:pr

github-actions[bot] commented 3 months ago

A new release has been made for this PR. You can install it with npm i @apollo/experimental-nextjs-app-support@0.0.0-commit-dee59cc.

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

sigh

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

/release:pr

phryneas commented 3 months ago

/release:pr

github-actions[bot] commented 3 months ago

A new release has been made for this PR. You can install it with npm i @apollo/experimental-nextjs-app-support@0.0.0-commit-fac6765.

phryneas commented 3 months ago

/release:pr

github-actions[bot] commented 3 months ago

A new release has been made for this PR. You can install it with npm i @apollo/experimental-nextjs-app-support@0.0.0-commit-c266287.

phryneas commented 3 months ago

/release:pr

github-actions[bot] commented 3 months ago

A new release has been made for this PR. You can install it with npm i @apollo/experimental-nextjs-app-support@0.0.0-commit-b271305.

luchillo17 commented 2 months ago

I've started checking out these changes and there's a lot to look at, but I see the description of the PR is very small, it would be nice to know what is the reason this PR exists, the title doesn't tell me much, is it a refactor for DRY principles? or is there a functional change in how data and/or UI are streamed to the client side?

phryneas commented 2 months ago

@luchillo17 We are in the process of separating this package into two separate ones - one more generic @apollo/client-react-streaming and the more specific @apollo/experimental-nextjs-app-support. This is necessary because other frameworks (e.g. RedwoodJs) are now adapting streaming SSR, and we want to add easier support for those.

This is the first of multiple PRs, and the follow-up PR with the actual package split is going over in https://github.com/apollographql/apollo-client-nextjs/pull/193

Honestly, I get that this is a lot, and you really don't need to review all of it - but it would be very helpful if you could give the feedback if jest keeps working for you as this progresses along :)

dac09 commented 2 months ago

🥳🥳🥳🥳🥳