search

apollographql / apollo-client-nextjs

Apollo Client support for the Next.js App Router
https://www.npmjs.com/package/@apollo/experimental-nextjs-app-support
MIT License
358 stars 25 forks source link

0.10.0 (1) - Throw error when passing arguments into `getClient`. #203

Closed phryneas closed 1 month ago

phryneas commented 2 months ago

It has come again and again that people are trying to do this, so we should be more strict about the fact that this is not supported.

Happy for any wording suggestions.

phryneas commented 2 months ago

Uhh, wtf. deleted the parent branch and now this is closed 🤦

This will need some serious rebasing later...

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.79 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.41 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.27 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.14 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.74 KB (0%)
@apollo/client-react-streaming (RSC ESM) 1.12 KB (+10.15% 🔺)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.46 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.34 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.41 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.33 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 857 B (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 406 B (+46.05% 🔺)
relativeci[bot] commented 1 month ago

Job #103: Bundle Size — 1.01MiB (0%).

96db8ed(current) vs fd40453 main#99(baseline)

[!WARNING] Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes
                 Current
Job #103		      Baseline
Job #99
No change  Initial JS 890.59KiB 890.59KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0.03% 0.03%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1

Bundle size by type  no changes
|            |       Current
[Job #103](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/103-xVdvK5x7ozUcCeaWFo66?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #99](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/99-FcF7ArGl2PBS0feFz08p?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/103-xVdvK5x7ozUcCeaWFo66/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `1023.85KiB` | `1023.85KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/103-xVdvK5x7ozUcCeaWFo66/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `5.99KiB` | `5.99KiB` |

View job #103 report View pr/getClient-forceNoParameters branch activity View project dashboard