search

apollographql / apollo-client-nextjs

Apollo Client support for the Next.js App Router
https://www.npmjs.com/package/@apollo/experimental-nextjs-app-support
MIT License
358 stars 25 forks source link

0.10.0 (2) - Warn if makeClient returns the same client for multiple requests. #205

Closed phryneas closed 1 month ago

phryneas commented 2 months ago

Yup, I wanted to make sure we actually want to do this before I get into the nitty-gritty of figuring out how to write a test against a RSC environment :)

relativeci[bot] commented 1 month ago

Job #106: Bundle Size — 1.01MiB (0%).

c127d4f(current) vs e0b4862 main#104(baseline)

[!WARNING] Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes
                 Current
Job #106		      Baseline
Job #104
No change  Initial JS 890.59KiB 890.59KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0.04% 0.04%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1

Bundle size by type  no changes
|            |       Current
[Job #106](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/106-ObDJ8rwwpzjjsDn1Af1B?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #104](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/104-KtwBvALpwE8clyGMA8Y5?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/106-ObDJ8rwwpzjjsDn1Af1B/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `1023.85KiB` | `1023.85KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/106-ObDJ8rwwpzjjsDn1Af1B/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `5.99KiB` | `5.99KiB` |

View job #106 report View pr/getClient-makeUniqueClients branch activity View project dashboard

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.79 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.41 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.27 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.14 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.74 KB (0%)
@apollo/client-react-streaming (RSC ESM) 1.33 KB (+18.68% 🔺)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.46 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.34 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.41 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.33 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 867 B (+1.17% 🔺)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 626 B (+54.19% 🔺)