Closed phryneas closed 1 month ago
I think this is ready for review now :)
37a3647(current) vs f823d31 main#11(baseline)
[!WARNING] Bundle contains 1 duplicate package – View duplicate packages
[!WARNING] Bundle introduced one new package: react-error-boundary – View changed packages
Bundle metrics
7 changes
3 regressions
Current Job #14 |
Baseline Job #11 |
|
---|---|---|
Initial JS | 889.61KiB (+0.36% ) |
886.43KiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 53.39% |
5.35% |
Chunks | 24 (+4.35% ) |
23 |
Assets | 45 (+4.65% ) |
43 |
Modules | 511 (+0.59% ) |
508 |
Duplicate Modules | 30 |
30 |
Duplicate Code | 1.3% (+2.36% ) |
1.27% |
Packages | 29 (+3.57% ) |
28 |
Duplicate Packages | 1 |
1 |
2 changes
2 regressions
View job #14 report View pr/adjust-datatransport branch activity View project dashboard
As I don't want to change the shape of the DataTransportAbstraction immediately after we released it for the first time, this one would also need to go into 0.9.0.
This switches from two very separate "request started" and "request finished" events to a stream of events with a shared identifier between queries.
This has the benefit that in the future we can easily track which events are still "unhandled", e.g. for keeping the connection open for longer.
Also, for the first time we detect & communicate errors that happened in SSR to the browser, to restart queries there immediately.
As a positive side-effect of having a "query identifier", the query document is sent only once, not twice over. That already plays a bit into #210. (Technically, it's sent one more time per hook, so we're down from three times to two).