search

apollographql / apollo-client-nextjs

Apollo Client support for the Next.js App Router
https://www.npmjs.com/package/@apollo/experimental-nextjs-app-support
MIT License
358 stars 25 forks source link

try to stabilize flimsy tests #266

Closed phryneas closed 1 month ago

phryneas commented 1 month ago

These tests fail from time to time, e.g. in this run: https://github.com/apollographql/apollo-client-nextjs/actions/runs/8523111570/job/23344752684

Let's see if we get them more stable?

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.79 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.41 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.25 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.12 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.72 KB (0%)
@apollo/client-react-streaming (RSC ESM) 1020 B (0%)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.43 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.32 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.4 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.3 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 839 B (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 261 B (0%)
relativeci[bot] commented 1 month ago

Job #91: Bundle Size — 1.01MiB (0%).

a4e1984(current) vs b508a5a main#88(baseline)

[!WARNING] Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes
                 Current
Job #91		      Baseline
Job #88
No change  Initial JS 890.59KiB 890.59KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0.04% 0.04%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1

Bundle size by type  no changes
|            |       Current
[Job #91](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/91-rF7CalS3tw8i4qn0CDh1?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #88](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/88-hjNSAU9xEobbje3MOFOD?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/91-rF7CalS3tw8i4qn0CDh1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `1023.85KiB` | `1023.85KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/91-rF7CalS3tw8i4qn0CDh1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `5.99KiB` | `5.99KiB` |

View job #91 report View pr/test-changes branch activity View project dashboard

phryneas commented 1 month ago

The infuriating thing is that these tests do not fail on localhost.

phryneas commented 1 month ago

But downgrading my local node to v20 does fail the unit tests... Bumping the node version to 21 for the unit tests.

phryneas commented 1 month ago

Logged as a node bug at https://github.com/nodejs/node/issues/52325 and pinned the node version for now.