search

apollographql / apollo-client-nextjs

Apollo Client support for the Next.js App Router
https://www.npmjs.com/package/@apollo/experimental-nextjs-app-support
MIT License
358 stars 25 forks source link

0.10.0 (4) default `connectToDevTools` to `false` in RSC and SSR builds #271

Closed phryneas closed 1 month ago

phryneas commented 1 month ago

closes #238

The last PR for 0.10.0.

This defaults connectToDevTools to false in RSC and SSR builds where connecting to the DevTools is impossible anyways, but might end up in a stray setTimeout that hangs around for 10 seconds which uses memory unneccessarily - and e.g. prevents tests from cleaning up correctly.

No tests for this since I'm not sure how correctly to test this - but I could remove a few connectToDevTools from our tests, which is nice. I looked at the built artefacts though, and it's picked up correctly.

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.78 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.4 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.27 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.13 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.75 KB (+0.96% 🔺)
@apollo/client-react-streaming (RSC ESM) 1.36 KB (+2.27% 🔺)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.45 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.34 KB (+0.17% 🔺)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.41 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.33 KB (+0.28% 🔺)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 867 B (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 626 B (0%)
relativeci[bot] commented 1 month ago

Job #110: Bundle Size — 1.01MiB (0%).

775d110(current) vs 100952e main#108(baseline)

[!WARNING] Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #110		      Baseline
Job #108
No change  Initial JS 890.58KiB 890.58KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0.03% 21.11%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1

Bundle size by type  no changes
|            |       Current
[Job #110](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/110-ElktwcsvlaqoWHMdbC4e?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #108](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/108-iBM1NSOqA2iQwDoz4AiM?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/110-ElktwcsvlaqoWHMdbC4e/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `1023.84KiB` | `1023.84KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/fukE5WxC5RnzLcZncFJw/jobs/110-ElktwcsvlaqoWHMdbC4e/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `5.99KiB` | `5.99KiB` |

View job #110 report View pr/connectToDevTools branch activity View project dashboard