useLazyQuery does not fire onCompleted when being used with "no-cache" and "network-only" fetchPolicy

[pt-hieu]

Issue Description

Hi Apollo Client team, I am running into an issue where onCompleted is not fired when running the execute function of useLazyQuery with fetchPolicy set to no-cache or network-only

const [execute] = useLazyQuery(
    gql`
      query Test($id: String!) {
        node(id: $id) {
          ... on Train {
            passengers {
              totalCount
            }
          }
        }
      }
    `,
    { client: apolloClient, variables: { id: "1" }, fetchPolicy: "no-cache" }
  );

  useEffect(() => {
    execute({
      onCompleted() {
        console.log("Hello world");
        alert("Hello world");
      },
    }).then((data) => {
      console.log("Hello from promise", data);
    });
  }, []);

The above snippet is from the reproduction repo, the expected behaviour would be to see an alert dialog appearing (because onCompleted gets called) but there's only 2 "Hello from promise" logs in console which means there's actual data returned

Note

• onCompleted had been previous called successfully in our production environment until I made some changes to cache's typePolicies which should not have affected useLazyQuery, though in the reproduction I don't touch typePolicies
• onCompleted is called again once I drop react's StrictMode
• I did place a break point at the condition evaluation of handleErrorOrCompleted (here) to debug and acknowledged that the condition is evaluated 3 times with the following values of result sequentially: { loading: true, networkStatus: 1 }, { loading: false, networkStatus: 7 } and { data: {...}, loading: false, networkStatus: 7 }. I don't think that is the correct behaviour

Link to Reproduction

https://github.com/pt-hieu/apollo-lazy-oncompleted-reproduce

Reproduction Steps

• Clone the reproduction repo git clone https://github.com/pt-hieu/apollo-lazy-oncompleted-reproduce.git
• Run pnpm i to install dependencies
• Run pnpm dev to bootstrap the dev server
• Access http://localhost:4200 and open the console panel at Info channel to see the log

[bignimbus]

Hi @pt-hieu 👋🏻 thanks for reporting this! Was there a version of Apollo Client you used where this was working?

[pt-hieu]

Thanks for replying @bignimbus, I am not sure about this but we previously used 3.7.14 and then upgraded the package to 3.8.4, one thing that I don't really understand is how our production does not have this bug