apollographql / apollo-client

:rocket:  A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server.
https://apollographql.com/client
MIT License
19.34k stars 2.66k forks source link

AutoCleanedCache: only schedule batched cache cleanup if the cache is full #11792

Closed phryneas closed 5 months ago

phryneas commented 5 months ago

Fixes #11790

This prevents timeouts from being set when they are not necessary.

This should probably go into a 3.10.1

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 992a2a388f1d131fa3425700079b7066f6010748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

phryneas commented 5 months ago

/release:pr

github-actions[bot] commented 5 months ago

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.62 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.5 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.05 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.17 KB (+0.06% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.06 KB (+0.07% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.28 KB (+0.34% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.37 KB (+0.45% 🔺)
import { useLazyQuery } from "dist/react/index.js" 5.52 KB (+0.32% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.59 KB (+0.39% 🔺)
import { useMutation } from "dist/react/index.js" 3.52 KB (+0.48% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.74 KB (+0.54% 🔺)
import { useSubscription } from "dist/react/index.js" 3.21 KB (+0.62% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (+0.91% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 5.46 KB (+0.4% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.12 KB (+0.5% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 4.94 KB (+0.48% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.59 KB (+0.58% 🔺)
import { useLoadableQuery } from "dist/react/index.js" 5.05 KB (+0.41% 🔺)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.71 KB (+0.53% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.31 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.25 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)
github-actions[bot] commented 5 months ago

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11792-20240419093048
netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name Link
Latest commit 992a2a388f1d131fa3425700079b7066f6010748
Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/662947b6ea1b4f0008e6600b
Deploy Preview https://deploy-preview-11792--apollo-client-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

phryneas commented 5 months ago

Tests are failing because playwright binaries can't be downloaded from archive.ubuntu.com right now. I'd assume that will pick up in a few hours.

phryneas commented 5 months ago

Tests did run again and are green.