Rename `NoInfer` to `LegacyNoInfer` for TS 5.4

jerelmiller commented 5 months ago

TypeScript 5.4 added official support for a built-in NoInfer type. This PR renames our existing NoInfer type to LegacyNoInfer and deprecates it in favor of the built-in type. This should allow us to merge the renovate PRs that are currently failing due to the extract API changes.

I figured we should probably keep it around for users that aren't on TS 5.4 yet.

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: e2b228da554050be70316a47dafd3e9587e556fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 5 months ago

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.62 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	46.5 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	44.05 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.17 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.06 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.21 KB (0%)
import { useQuery } from "dist/react/index.js"	5.28 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.52 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.59 KB (0%)
import { useMutation } from "dist/react/index.js"	3.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.74 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.12 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.59 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.05 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.71 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.31 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.25 KB (0%)
import { useFragment } from "dist/react/index.js"	2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.23 KB (0%)

netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	fa0018a36b8fc72e8c9477c4996b39c1e0a60f66
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6632ca9b74ab68000802b9ce
Deploy Preview	https://deploy-preview-11822--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	e2b228da554050be70316a47dafd3e9587e556fb
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6632cb16c20e9500089bb4eb
Deploy Preview	https://deploy-preview-11822--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

phryneas commented 5 months ago

Don't we just need to rerun api-extractor? This shouldn't cause any conflict, just shadow the original type until we drop the polyfill.

jerelmiller commented 5 months ago

@phryneas that works too. I tried running it in a branch that updates the api extractor and it renamed our exported type to NoInfer_2, hence my thought about just renaming it generally. I'm not attached to this change, so I'm ok if we just regen as-is. Let me open a separate PR and we can decide which we like better.

jerelmiller commented 5 months ago

Closing in favor of #11823

apollographql / apollo-client