Closed ach5910 closed 1 month ago
Hi @ach5910 👋🏻 thanks for letting us know! I'll chat with the team soon to see if there's anything that immediately jumps out as a bug in Apollo Client. Are you able to reproduce this issue in a clean app (e.g. without the other libraries)?
Facing the same error, is there any way we can kill all pending active queries other than clearStore?
@bignimbus Unfortunately I couldn't reproduce the bug in a sandboxed app due to the complexity of mirroring our production app's infrastructure. I know that not much help in diagnosing the problem, but I was really hoping I was missing something basic and I'd get a "RTFD" response.
@Nehal-Zeller I found a solution by calling client.cache.reset()
instead of client.clearStore()
or client.resetStore()
. I believe any active requests will update the cache if returned after resetting, but it beats having the app crash. Hope this helps!
I am facing the same issue. I believe that client.cache.reset()
is not killing the pending query thus it will be written to cache once the response is returned.
It's worth to mention that i am encountering this error randomly on react native. I can't easily reproduce that.
Am also facing this issue for a while now. Upgraded to @apollo/client@3.11.1
and am still able to reproduce this error by running a query and then calling client.clearStore()
.
@DerekWang98 are you seeing the same stack trace and error as the issue description (unexpected), or are you seeing an error with a message of Store reset while query was in flight (not completed in link chain)
. If the latter, this is expected behavior, but if the former, then a reproduction of the issue would be greatly appreciated.
Hey @jerelmiller, I get the same error stack trace error in node_modules/@apollo/client/react/hooks/useQuery.js
To reproduce the issue, go to search in the sandbox preview and press "OK" to reproduce the bug. I ran a lazy query and then quickly performed clearStore()
in /src/components/Search.js
to simulate it.
Thanks for looking into it!
@DerekWang98 I can reproduce your situation, but it's a different bug.
Your codepath comes from complete
while the original issue comes from notifySubscription
. I'll move this over to a new issue :)
Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.
While we can't 100% reproduce it, I believe this will be solved once we release #11989 in the next patch release of Apollo Client.
If that isn't the case, let's open a new issue on this :)
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. For general questions, we recommend using StackOverflow or our discord server.
Issue Description
If
client.clearStore
is called while a query response is pending, it's causing a crashing at this location https://github.com/apollographql/apollo-client/blob/main/src/react/hooks/useQuery.ts#L635.I am using
apollo3-cache-persist@0.14.1
apollo-link-token-refresh@0.6.1
@muchobien/apollo-persistence-mapper@npm:^1.0.0
apollo-link-sentry@3.3.0
and here's how I am initializing my client
I've also tried using
resetStore
, but I get the same error. Any feedback regarding a potential cause is greatly appreciated.Link to Reproduction
N/A
Reproduction Steps
No response
@apollo/client
version3.9.11