start testing with React 19

phryneas commented 5 months ago

Excluding the HOC/Render Props tests, which I just disabled for React 19, we only have ~three~ ~two~ ~one~ no failing tests with React 19.

I'd call that a win :)

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: bcce10cee934563056c53cf96151e15b76ee73c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 5 months ago

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.69 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	47.47 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	45.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.2 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.22 KB (0%)
import { useQuery } from "dist/react/index.js"	5.29 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.57 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.64 KB (0%)
import { useMutation } from "dist/react/index.js"	3.54 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.77 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.33 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.27 KB (0%)
import { useFragment } from "dist/react/index.js"	2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.23 KB (0%)

netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	c765bd9d830afbb9559610582347cc93a714bed6
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6666d90b62d82b000898ea8f
Deploy Preview	https://deploy-preview-11883--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	c97f4c630a2cb324a9d15c6ed116f93f4a4354ef
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6666da384db2cb000841c14f
Deploy Preview	https://deploy-preview-11883--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	654f82cfc70d3df28da0102bfa898d827ab781b0
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6666e60b6c3c1300092439c5
Deploy Preview	https://deploy-preview-11883--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	bcce10cee934563056c53cf96151e15b76ee73c8
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/666812e01bd2d40008c8004f
Deploy Preview	https://deploy-preview-11883--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

phryneas commented 5 months ago

Down to one failed test - it seems that for some reason use is a lot slower in React 19 than our React 18 polyfill.

This test takes about 5 seconds longer in React 19 with use vs React 19 with __use:

https://github.com/apollographql/apollo-client/blob/8e3edd4f5e5191453ba3ca1a1cc4fc4a02b936e8/src/react/hooks/__tests__/useSuspenseQuery.test.tsx#L9519-L9615

apollographql / apollo-client