Add `.d.cts` files for cjs bundles

phryneas commented 4 months ago

An experiment in the context of stuff Danny Choudhury is currently doing for Redwood - maybe as a temporary fix until we can do the major with exports.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 5af068a53a6ac374389acb70f96a6e9729b87edb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

phryneas commented 4 months ago

/release:pr

github-actions[bot] commented 4 months ago

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11905-20240624123001

github-actions[bot] commented 4 months ago

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.65 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	47.43 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	45 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.2 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.06 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.22 KB (0%)
import { useQuery } from "dist/react/index.js"	5.3 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.58 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.65 KB (0%)
import { useMutation } from "dist/react/index.js"	3.57 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.79 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.41 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.45 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.11 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.67 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.34 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.28 KB (0%)
import { useFragment } from "dist/react/index.js"	2.3 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.24 KB (0%)

phryneas commented 4 months ago

/release:pr

netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	394eb0d38073abc6aed772bd28859bca6b12e372
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/667966a773fd3c0008f517c3
Deploy Preview	https://deploy-preview-11905--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 months ago

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11905-20240624123524

netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	5af068a53a6ac374389acb70f96a6e9729b87edb
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/667b1ce7a6f31800085926c7
Deploy Preview	https://deploy-preview-11905--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jerelmiller commented 4 months ago

Would this fix https://github.com/apollographql/apollo-client/issues/11895 as well by chance?

phryneas commented 4 months ago

Would this fix https://github.com/apollographql/apollo-client/issues/11895 as well by chance?

Not by itself, but then they could at least import @apollo/client/main.cjs manually and get correct types.

phryneas commented 4 months ago

So, I guess we go forward with this for now, but we'll keep the right to break directly importing .cjs files in the next major, in favor of an exports field?

apollographql / apollo-client