Allow `undefined` as return value from `cache.modify` modifier function

jerelmiller commented 4 months ago

Version 3.7.x allowed undefined as a valid return value when using cache.modify. When doing so, this essentially caused the query to be refetched since the field data was removed. 3.8.x added some more robust types for cache.modify with https://github.com/apollographql/apollo-client/pull/10895, but as a result, we lost the ability to return undefined from these functions. Since the behavior is identical in > 3.8.x we should still allow this as a valid value since the client handles this correctly.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 0a559d1aef6583384d5aedcb5d6414c6d0ec28fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 months ago

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.68 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	47.48 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	45.05 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.22 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.08 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.32 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.39 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.6 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.67 KB (0%)
import { useMutation } from "dist/react/index.js"	3.59 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.81 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.23 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.43 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.47 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.12 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.98 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.63 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.04 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.35 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.3 KB (0%)
import { useFragment } from "dist/react/index.js"	2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.27 KB (0%)

netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	0a559d1aef6583384d5aedcb5d6414c6d0ec28fd
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/667db52a9bec590008daf51d
Deploy Preview	https://deploy-preview-11911--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jerelmiller commented 4 months ago

Got a verbal approval from Ben on allowing this so I'm going to go ahead and merge it 🙂

apollographql / apollo-client