search

apollographql / apollo-client

:rocket:  A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server.
https://apollographql.com/client
MIT License
19.34k stars 2.66k forks source link

Fix `optimisticResponse` function return type #11944

Closed sneyderdev closed 2 months ago

sneyderdev commented 2 months ago

Fixes #11945

This PR fixes returning the IGNORE sentinel object from optimisticResponse when inferring the result data of a generic TypedDocumentNode mutation.

apollo-cla commented 2 months ago

@sneyderdev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

netlify[bot] commented 2 months ago

Deploy Preview for apollo-client-docs ready!

Name Link
Latest commit ee4dff0d6b9f7d9ba54c77883dbf9c178c56a3b0
Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6694d095a7f05e0008a53f28
Deploy Preview https://deploy-preview-11944--apollo-client-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 2f4ee90703d4b697cc6512eceae2a505383ec5ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sneyderdev commented 2 months ago

Good catch, and thank you for the PR! Could you please sign the Contributor License Agreement so we can get this in? :)

Oh, I just did it again but I'm not sure what's wrong. I'm getting this confirmation message and the confirmation email doesn't have any extra steps. Am I missing anything? image

phryneas commented 2 months ago

Let me ask around internally :)

abernix commented 2 months ago

I'm getting this confirmation message and the confirmation email doesn't have any extra steps. Am I missing anything?

There are no additional steps in the email. The CLA status checks are passing now, so I think you're all good. I'll let the repository folks take care of merging this.

There is one failing status check, but not sure if it's load bearing:

❌ Clean up Prettier, Size-limit, and Api-Extractor / add_cleanup_label (pull_request_review) Failing after 10s

😄 Hope this helps!

phryneas commented 2 months ago

Ah, it seems I missed that that is passing now - it wasn't earlier 😅