apollographql / apollo-client

:rocket:  A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server.
https://apollographql.com/client
MIT License
19.38k stars 2.66k forks source link

Fix issue accessing mutations from devtools #11946

Closed jerelmiller closed 4 months ago

jerelmiller commented 4 months ago

https://github.com/apollographql/apollo-client/pull/11936 introduced a new way to configure devtools so that we can add support for additional options in the future to enable new capabilities. Unfortunately I forgot to replace a reference to connectToDevtools in the constructor for the onBroadcast option which is needed to create the mutationStore accessed by devtools. As such, mutations were not showing up in devtools.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: b92c06f6a2204ac43c9ca3584f46c347295d2eac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jerelmiller commented 4 months ago

/release:pr

github-actions[bot] commented 4 months ago

Please add a changeset via npx changeset before attempting a snapshot release.

github-actions[bot] commented 4 months ago

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.24 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.99 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.51 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.34 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.2 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.24 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.31 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.79 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.16 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.65 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.34 KB (0%)
import { useFragment } from "dist/react/index.js" 2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.27 KB (0%)
jerelmiller commented 4 months ago

/release:pr

github-actions[bot] commented 4 months ago

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11946-20240710142240
netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name Link
Latest commit 9d74e32829f0c5b8e810bd8df718fa4abc057e94
Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e9895858a560008626848
Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jerelmiller commented 4 months ago

Oops, I suppose I do need that changeset after all so that we can trigger a new rc. I'll add it back 😆

netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name Link
Latest commit 4c1ce936671955a139ccb19d02f10f07690f153f
Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e98fb9a1e9600071551e1
Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name Link
Latest commit b85819818e9f36f3bc75b1b39580d5d9238d365b
Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e9a4906d0a300087b3281
Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Deploy Preview for apollo-client-docs ready!

Name Link
Latest commit b92c06f6a2204ac43c9ca3584f46c347295d2eac
Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e9bf9e96d3000089226ab
Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.