Closed jerelmiller closed 2 months ago
changeset-bot[bot]
commented
2 months ago Latest commit: f7d7b53721ed6bc0d8bbd390766ce9d72608968f
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
github-actions[bot]
commented
2 months ago | Path | Size |
|---|---|
| dist/apollo-client.min.cjs | 39.22 KB (-0.03% 🔽) |
| import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" | 47.88 KB (-0.02% 🔽) |
| import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) | 45.45 KB (-0.02% 🔽) |
| import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" | 34.32 KB (-0.03% 🔽) |
| import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) | 32.2 KB (-0.03% 🔽) |
| import { ApolloProvider } from "dist/react/index.js" | 1.26 KB (0%) |
| import { ApolloProvider } from "dist/react/index.js" (production) | 1.24 KB (0%) |
| import { useQuery } from "dist/react/index.js" | 5.21 KB (0%) |
| import { useQuery } from "dist/react/index.js" (production) | 4.3 KB (0%) |
| import { useLazyQuery } from "dist/react/index.js" | 5.69 KB (0%) |
| import { useLazyQuery } from "dist/react/index.js" (production) | 4.77 KB (0%) |
| import { useMutation } from "dist/react/index.js" | 3.62 KB (0%) |
| import { useMutation } from "dist/react/index.js" (production) | 2.84 KB (0%) |
| import { useSubscription } from "dist/react/index.js" | 4.41 KB (0%) |
| import { useSubscription } from "dist/react/index.js" (production) | 3.46 KB (0%) |
| import { useSuspenseQuery } from "dist/react/index.js" | 5.49 KB (0%) |
| import { useSuspenseQuery } from "dist/react/index.js" (production) | 4.15 KB (0%) |
| import { useBackgroundQuery } from "dist/react/index.js" | 4.99 KB (0%) |
| import { useBackgroundQuery } from "dist/react/index.js" (production) | 3.64 KB (0%) |
| import { useLoadableQuery } from "dist/react/index.js" | 5.07 KB (0%) |
| import { useLoadableQuery } from "dist/react/index.js" (production) | 3.72 KB (0%) |
| import { useReadQuery } from "dist/react/index.js" | 3.39 KB (0%) |
| import { useReadQuery } from "dist/react/index.js" (production) | 3.33 KB (0%) |
| import { useFragment } from "dist/react/index.js" | 2.32 KB (0%) |
| import { useFragment } from "dist/react/index.js" (production) | 2.27 KB (0%) |
jerelmiller
commented
2 months ago /release:pr
github-actions[bot]
commented
2 months ago A new release has been made for this PR. You can install it with:
npm i @apollo/client@0.0.0-pr-11969-20240723020017Can confirm this fixes the issue.
netlify[bot]
commented
2 months ago | Name | Link |
|---|---|
| Latest commit | f7d7b53721ed6bc0d8bbd390766ce9d72608968f |
| Latest deploy log | https://app.netlify.com/sites/apollo-client-docs/deploys/669fb9849c3e1700087a861a |
| Deploy Preview | https://deploy-preview-11969--apollo-client-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
jerelmiller
commented
2 months ago @phryneas probably not. I opened an issue about it a while ago (https://github.com/apollographql/apollo-client/issues/11707), but haven't acted upon it yet. You think a patch release would be an ok time to remove the additional unneeded checks? We should be able to simplify to just the __DEV__ check from here on out.
Closes #11707
I made an error and incorrectly copied over the default value to connect to devtools. I forgot the
!to check if there is already a global client instance 🤦♂️.Regardless, this gives us a chance to re-evaluate the check. Now that Apollo Client Devtools supports multiple clients, we can remove the additional checks for
window.__APOLLO_CLIENT__when determining how to set the default value. The check will now simply look at__DEV__to determine whether to connect the client or not when the option is not specified.