Don't attempt to connect to devtools in non-browser environments

jerelmiller commented 2 months ago

This was mostly already doing this. With https://github.com/apollographql/apollo-client/pull/11969, we removed the check for typeof window to set the default value for devtools.enabled. The connectToDevtools function has some checks for typeof window as well, but currently it allows the setTimeout to run before it checks for typeof window.

This PR simplifies this by returning early if typeof window is undefined.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 272000f1c8da41a63e977d8e6209582b7e1ce605

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @apollo/client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	39.22 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	47.88 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	45.45 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.31 KB (-0.02% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.2 KB (-0.01% 🔽)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.77 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.41 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.49 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.15 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.99 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.64 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.33 KB (0%)
import { useFragment } from "dist/react/index.js"	2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.27 KB (0%)

netlify[bot] commented 2 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	cef8ebb31f5383b2d352b104036c7f62b77c2e61
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/669fc11413b16a0008c9b8e3
Deploy Preview	https://deploy-preview-11971--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	6a52c58a1a6f912ceaa12e8cf8d28446d4643b6b
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/669fc1f32f1ed400086db8ea
Deploy Preview	https://deploy-preview-11971--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for apollo-client-docs ready!

Name	Link
Latest commit	272000f1c8da41a63e977d8e6209582b7e1ce605
Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/669fc2a9ff55810008e96f9f
Deploy Preview	https://deploy-preview-11971--apollo-client-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apollographql / apollo-client