graphQLErrors is empty in promise chain

mydearxym commented 6 years ago

i am using apollo-client@2.0.4 standalone with the basic setup:

const graphLink = new HttpLink({ uri: 'http://localhost:4001/graphiql' })

const errorLink = onError(({ graphQLErrors }) => {
  if (graphQLErrors) {
    graphQLErrors.map(
      ({ message, path, detail }) =>
      >  graphQLErrors has value here
        debug(`[GraphQL error-- ]: ${path} ${message} ${detail}`)
    )
  }
})

const link = ApolloLink.from([errorLink, graphLink])

const client = new ApolloClient({
  link,
  cache: new InMemoryCache(),
})

the graphQLErrors result in onError block is right. this is the grahql-playground result:

but the graphQLErrors is empty in the promise-catch block

const QUERY = `
{
  allUsers2 {
    entries {
      username
    }
    totalCount
    pageSiz
  }
}
`
const query = gql`
    ${QUERY}
  `

  client
    .query({
      query,
      context,
    })
    .then(data => {
      debug(data)
    })
    .catch(({ graphQLErrors, message }) => {
      if (graphQLErrors) {
    >   graphQLErrors is Empty here 
        /* debug('【catch graphQLErrors:】 ', graphQLErrors) */
      }
    })

dizlexik commented 6 years ago

I'm having the same issue of graphQLErrors being empty, even though the server response has one or more errors in it.

My code, unchanged, worked as expected before upgrading to Apollo v2 from v1. So some change in v2 is preventing graphQLErrors from being populated like it was in v1, and I can't figure what that is. This has broken all of the error handling in my application :/

KevinHewson commented 6 years ago

I'm having the same issue as this. Any updates? It looks like the error exists in the networkErrors but not in the graphQLErrors.

Mati365 commented 6 years ago

any updates?

Mati365 commented 6 years ago

I found simple fix: err.networkError.result.errors, invoking it in catch() handlers will fix problem

mi-mazouz commented 6 years ago

any updates?

@Mati365 the error should be in graphQLErrors, in my case if the error is from the resolver graphQLErrors is not empty but when the error come from apollo-server-express context the error is in networkError. and graphQLErrors is empty!

That does not make sense and I don't want to handle 2 cases in my catch statement!

pfarnach commented 5 years ago

I'm also seeing this issue. My server returns a 400 response that looks like:

{
  "errors":[
    {"message":"Invalid email or password."}
  ],
  "data":{"logIn":null}
}

The onError middleware correctly passes this through in the graphQLErrors array (along with a networkError), but by the time it gets to the Mutation component's error object, graphQLErrors is an empty array. The err.networkError.result.errors trick works but is hacky. Any thoughts?

jbaxleyiii commented 5 years ago

Thanks for reporting this. There hasn't been any activity here in quite some time, so we'll close this issue for now. If this is still a problem (using a modern version of Apollo Client), please let us know. Thanks!

pfarnach commented 5 years ago

I just posted last month and it's still a problem. I don't think this issue should be closed.

cybernetlab commented 5 years ago

+1 problem is still here

patpaev commented 5 years ago

+1 please re-open, still seeing this behavior in latest the version

ThisIsRuddy commented 5 years ago

I too am experiencing this problem today All the errors returned from GQL are populated in the networkError property as opposed to the graphQLErrors array when using a mutation.

Edit: I am now extracting errors with some custom functions

import {get} from 'lodash'

export async function extractFirstError(e) {
    const errorPaths = [
        'graphQLErrors[0].message',
        'networkError.result.errors[0].message',
        'response.errors[0].message',
        'message'
    ]
    const path = errorPaths.find(path => get(e, path))
    return get(e, path)
}

export async function extractErrors(e) {
    const errors = []
    const errorPaths = [
        'graphQLErrors',
        'networkError.result.errors',
        'response.errors'
    ]
    const paths = errorPaths.filter(path => get(e, path))
    paths.forEach(path => errors.push(...get(e, path)))
    return errors ? errors : [e]
}

amirqasemi74 commented 4 years ago

I have still the same problem...

"apollo-boost": "^0.4.7", -"@apollo/react-hooks": "^3.1.3", why it is closed???!!!

SachaG commented 4 years ago

I'm also running into this. Should a new issue be opened?

cmnstmntmn commented 4 years ago

any updates on this?

autumnwoodberry commented 4 years ago

Having this same problem still with v2.6.10

pfarnach commented 4 years ago

Unfortunately 95% of the Github issue emails I get are from people like me running into issues with this library. You may consider using a different tool like urql or writing raw GraphQL queries/mutations paired with something like react-query to handle caching and request state.

Mati365 commented 4 years ago

@pfarnach Totally agree, using plain simple fetch() for GQL queries is still less irritating than fighting with many abonated bugs like it in this piece of shit

earnubs commented 4 years ago

@apollo/client@3.0.0-rc.10

graphQLErrors array is empty, but networkError.result.errors has GraphQL errors.

After a bit of further reading... (https://www.apollographql.com/blog/full-stack-error-handling-with-graphql-apollo-5c12da407210)

A graphQLError is an error that occurs in a resolver, a networkError happens outside a resolver:

For example, the client failed to connect to your GraphQL endpoint, or some error occurred within your request middleware, or there was an error in the parse/validation phase of your query.

By that definition I don't have a bug, but perhaps renaming the fields might help make this less of a foot gun? Maybe rename graphQLErrors to resolverErrors so that (for those of us who don't read all the docs) we don't mistake parsing/validation errors for resolver errors.

liho00 commented 3 years ago

Thanks for reporting this. There hasn't been any activity here in quite some time, so we'll close this issue for now. If this is still a problem (using a modern version of Apollo Client), please let us know. Thanks!

this error still exists in 2021, why???