504 Gateway Timeout Unexpected token < in JSON at position 0

[chrisbradleydev]

Intended outcome: In the event Nginx times out on a long request parseAndCheckHttpResponse should gracefully handle the 504 error.

Actual outcome: When a 504 error occurs the response returned is HTML causing the following error: Unexpected token < in JSON at position 0 which masks the underlying issue.

How to reproduce the issue: This is demonstrated here by @david-golightly-leapyear

Versions System: OS: macOS 10.15.7 Binaries: Node: 12.19.0 - ~/n/bin/node Yarn: 1.22.10 - /usr/local/bin/yarn npm: 6.14.8 - /usr/local/bin/npm Browsers: Chrome: 86.0.4240.183 Edge: 86.0.622.63 Firefox: 80.0.1 Safari: 14.0 npmPackages: apollo: ^2.31.0 => 2.31.0 apollo-cache-inmemory: ^1.6.5 => 1.6.6 apollo-client: ^2.6.8 => 2.6.10 apollo-link-context: ^1.0.19 => 1.0.20 apollo-link-debounce: ^2.1.0 => 2.1.0 apollo-link-error: ^1.1.12 => 1.1.13 apollo-link-persisted-queries: ^0.2.2 => 0.2.2 apollo-link-retry: ^2.2.15 => 2.2.16 apollo-link-state: ^0.4.2 => 0.4.2 apollo-link-ws: ^1.0.19 => 1.0.20 apollo-upload-client: ^14.1.2 => 14.1.2 apollo-utilities: ^1.3.3 => 1.3.4 vue-apollo: 3.0.3 => 3.0.3 vue-cli-plugin-apollo: ^0.21.3 => 0.21.3

[jdrydn]

@chrisbradleydev See https://github.com/apollographql/apollo-feature-requests/issues/153 for a similar issue & discussion. This https://github.com/apollographql/apollo-feature-requests/issues/153#issuecomment-476832408 fixed it for me!

[jpvajda]

The team is considering this enhancement soon.

[dgallardox]

Any updates on this? Would love to see this return a better message

[jpvajda]

@dgallardox 👋 We don't have a target release for this as yet, but we do know it has a fair amount of interest. 😄 You can also see this option for a potential workaround