Option to persist errors while query is polling or refetching

Problem: Right now, we have a query with a polling interval, and we read loading, error, and data from the return results. We then render different error and loading UIs based on the return values:

const { data, loading, error } = useCustomHookGeneratedFromCodegen({
  pollingInterval: 3 seconds,
})

if (loading) return (
   <Loading />
)

if (error) return (
  <Error />
)

The problem is since there is a polling interval combined with error handling, error becomes undefined when the query is in a polling state, and result is that the UI flickers between the Error component and the Loading component.

Solutions we could try:

We could wrap each of our custom query hooks in a HOF hook that captures the result of error and saves it in state until the next poll returns
We can create a new usePersistedError that does the same persistence of error state but outside of a custom hook wrapper

However, we're using this pattern throughout our codebase so it's a little annoying to have to do this everywhere.

Suggested solution: Allow us to pass in a custom QueryHookOption: persistError that we can set at the global level that basically persists any previously returned errors while the network status is either refetching or loading.

Notes And of course if there's already an easy way to do this, lmk 😅

apollographql / apollo-feature-requests

Option to persist errors while query is polling or refetching #348