search

apollographql / apollo-federation-subgraph-compatibility

A repo to test subgraph libraries compatibility with the Apollo Federation Specification
https://www.apollographql.com/docs/federation/building-supergraphs/supported-subgraphs/
MIT License
77 stars 58 forks source link

Make `--failOnRequired` and `--failOnWarning` work together. #508

Closed myronmarston closed 1 year ago

myronmarston commented 1 year ago

--failOnWarning is a stricter flag than --failOnRequired and you don't need to pass --failOnRequired if you pass --failOnWarning. However, if you did pass both, it would ignore --failOnWarning because it checked --failOnWarning first (and then returned). By checking the stricter --failOnWarning flag first, it works correctly whether --failOnWarning is passed alone or together with --failOnRequired.

Fixes #507.

apollo-cla commented 1 year ago

@myronmarston: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

myronmarston commented 1 year ago

There's some hoops I have to jump through to sign the CLA. For such a small one-off fix it doesn't seem worth jumping through those hoops so I'm going to close this.