apollographql / apollo-federation-subgraph-compatibility

A repo to test subgraph libraries compatibility with the Apollo Federation Specification
https://www.apollographql.com/docs/federation/building-supergraphs/supported-subgraphs/
MIT License
77 stars 58 forks source link

add inventory type to sangria implementation to pass test for @interfaceObject support #554

Closed oskargotte closed 1 year ago

oskargotte commented 1 year ago

Bump sangria-federation to latest version which supports the @interfaceObject directive. Add the Inventory entity object type with Key and InterfaceObject directives to the schema in order to pass the compatibility test for @interfaceObject.

apollo-cla commented 1 year ago

@oskargotte: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

github-actions[bot] commented 1 year ago

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟒
@key (single)🟒
@key (multi)🟒
@key (composite)🟒
repeatable @key🟒
@requires🟒
@provides🟒
federated tracing🟒
@link🟒
@shareable🟒
@tag🟒
@override🟒
@inaccessible🟒
@composeDirectiveπŸ”²
@interfaceObject🟒
dariuszkuc commented 1 year ago

@oskargotte is this still a draft?

dariuszkuc commented 1 year ago

Looks like @composeDirective (https://github.com/sangria-graphql/sangria-federated/issues/221) is also supported. Do you mind updating the test to also cover that scenario?

oskargotte commented 1 year ago

@oskargotte is this still a draft?

Well it’s pretty much finilized but I wanted to give @yanns a chance to provide feedback before merging it.

oskargotte commented 1 year ago

Looks like @composeDirective (sangria-graphql/sangria-federated#221) is also supported. Do you mind updating the test to also cover that scenario?

Yes the composeDirective is supported in sangria-federated but I'll have to read up on the requirements to get the tests to pass. I can target that one in another PR.

oskargotte commented 1 year ago

@oskargotte is this still a draft?

Well it’s pretty much finilized but I wanted to give @yanns a chance to provide feedback before merging it.

Should be ready to merge now @dariuszkuc