Closed oskargotte closed 1 year ago
@oskargotte: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/
Federation 1 Support | Federation 2 Support | ||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@oskargotte is this still a draft?
Looks like @composeDirective
(https://github.com/sangria-graphql/sangria-federated/issues/221) is also supported. Do you mind updating the test to also cover that scenario?
@oskargotte is this still a draft?
Well itβs pretty much finilized but I wanted to give @yanns a chance to provide feedback before merging it.
Looks like
@composeDirective
(sangria-graphql/sangria-federated#221) is also supported. Do you mind updating the test to also cover that scenario?
Yes the composeDirective is supported in sangria-federated but I'll have to read up on the requirements to get the tests to pass. I can target that one in another PR.
@oskargotte is this still a draft?
Well itβs pretty much finilized but I wanted to give @yanns a chance to provide feedback before merging it.
Should be ready to merge now @dariuszkuc
Bump sangria-federation to latest version which supports the @interfaceObject directive. Add the Inventory entity object type with Key and InterfaceObject directives to the schema in order to pass the compatibility test for @interfaceObject.